Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v7.2x increasing memory requirements to build #13828

Closed
3 tasks done
tw-hx opened this issue Dec 8, 2024 · 2 comments
Closed
3 tasks done

v7.2x increasing memory requirements to build #13828

tw-hx opened this issue Dec 8, 2024 · 2 comments
Labels

Comments

@tw-hx
Copy link
Contributor

tw-hx commented Dec 8, 2024

Guidelines

  • I have searched searched open and closed issues for duplicates
  • I am submitting a bug report for existing functionality that does not work as intended
  • This isn't a feature request or a discussion topic

Bug description

I've noticed recent rapidly escalating memory requirements to build Signal Android from source. I used to be able to build comfortably with 16Gb RAM, then with v7.25 it started hitting swap space hard, and v7.26 required 24Gb RAM/swap. I can just build it using a standard ubuntu-latest GitHub Actions runner with the addition of an 8Gb swapfile. The peak demand for RAM seems to be during R8 minifying. The resulting APK size has hardly changed.

On Signal's end it seems the JVM max heap size was increased from 6Gb to 12Gb three weeks ago as this became apparent. Sorry I haven't bisected the exact change responsible.

Would it be possible to look into what's bloating the build requirements? At least for reproducibility testing it might be ideal to target building well on a standard Github "ubuntu-latest" image?

Also, another recent upstream change I've noticed is the need for stripping the symbols from binaries of libsignal-android (v0.53.0 .. v0.54.0) and ringrtc-android (v2.48.0 .. v2.48.1), which used to be shipped as smaller stripped libraries. This means that unless the NDK is installed, the APK size is a lot bigger and not reproducible. In Signal-Android, these affected the v7.14 and v7.19 APK sizes.

Screenshots

No response

Device

No response

Android version

No response

Signal version

No response

Link to debug log

No response

Copy link

stale bot commented Feb 6, 2025

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Feb 6, 2025
Copy link

stale bot commented Feb 14, 2025

This issue has been closed due to inactivity.

@stale stale bot closed this as completed Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

1 participant