Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyPi Logo Image Broken #40

Closed
Teque5 opened this issue Dec 20, 2023 · 1 comment · Fixed by #43
Closed

PyPi Logo Image Broken #40

Teque5 opened this issue Dec 20, 2023 · 1 comment · Fixed by #43
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@Teque5
Copy link
Collaborator

Teque5 commented Dec 20, 2023

The published package on PyPi uses the README.md as the documentation, and the logo at the top is broken when viewed. As this image come from the main SigMF spec repo, I suspect the issue is that GitHub blocks hotlinking from external domains.

Not sure of fix; need to see how other packages handle embedded images in PyPi.

@Teque5 Teque5 added documentation Improvements or additions to documentation good first issue Good for newcomers labels Dec 20, 2023
@Teque5 Teque5 closed this as completed in #43 Jan 4, 2024
@Teque5
Copy link
Collaborator Author

Teque5 commented Jan 4, 2024

This issue is closed, but the updated documentation won't be visible on PyPi until a new release is created commensurate with a new version #. There are 2 pending PRs so I think this will happen soon. Thanks again to @aromanielloNTIA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant