Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check statements with cargo check #70

Closed
sigmaSd opened this issue Sep 29, 2020 · 1 comment
Closed

Check statements with cargo check #70

sigmaSd opened this issue Sep 29, 2020 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@sigmaSd
Copy link
Owner

sigmaSd commented Sep 29, 2020

The initial issue #67

Currently we don't do any check if the input is a statement, this is so the repl feels fast for those operations at least.

But still its weird when errors only appears after using an expression.

I tested cargo check and it turns out its not that slow, so its ok to use it to check each statement,

Also this behaviour should be configurable.

@sigmaSd sigmaSd added enhancement New feature or request good first issue Good for newcomers labels Sep 29, 2020
@sigmaSd
Copy link
Owner Author

sigmaSd commented Oct 11, 2020

@fdncred I believe that #67 is now correctly fixed.

@sigmaSd sigmaSd closed this as completed Oct 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant