Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong macOS configuration path #147

Open
yo-goto opened this issue Dec 18, 2024 · 5 comments
Open

Wrong macOS configuration path #147

yo-goto opened this issue Dec 18, 2024 · 5 comments

Comments

@yo-goto
Copy link

yo-goto commented Dec 18, 2024

First of all, it seems that the config path for macOS in the README is incorrect. I checked the real path by using irust -h.

wrong: /Users/$USER/Library/Preferences/irust/config.toml 

correct: /Users/$USER/Library/Application Support/irust/config.toml

As mentioned above, the location of the path on macOS being in Application Support, which is not very user-friendly, is problematic. I feel that many macOS users prefer to place their config files under ~/.config/. For example, tools like Nushell default to placing config files in Application Support, but some users are dissatisfied with this setup.

Personally, I think the best approach is the one used by Alacritty, where config files are searched for in the following locations. Would it be possible to adopt a similar configuration setup?

$XDG_CONFIG_HOME/alacritty/alacritty.toml
$XDG_CONFIG_HOME/alacritty.toml
$HOME/.config/alacritty/alacritty.toml
$HOME/.alacritty.toml
@yo-goto
Copy link
Author

yo-goto commented Dec 18, 2024

I noticed that when irust is launched, the above configuration file gets overwritten and reverts back to the default config.

@sigmaSd
Copy link
Owner

sigmaSd commented Dec 18, 2024

I updated the readme with the real path, If you want to change the location that's ok with me (I don't use mac so I don't have a strong opinion here) , feel free to open a PR
In the mean times you can use these variables to change where the configuration is located
image

@sigmaSd
Copy link
Owner

sigmaSd commented Dec 18, 2024

For the the second issue you mentioned: if you close all instances of irust, then modify the config files then open irust, it should work , otherwise its a new bug
the issue you're seeing is probably #142

@yo-goto
Copy link
Author

yo-goto commented Dec 20, 2024

Yes, after closing an instance of irust, editing the configuration file, and then launching irust again, the modified settings are not applied. Upon opening the configuration file again, it is confirmed to have reverted to the default settings.

@sigmaSd
Copy link
Owner

sigmaSd commented Dec 20, 2024

Then it's a different bug but I can't reproduce on Linux, so this might take some time to get fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants