get_artist returns different channelId for some artists

[Schtenk]

You missunderstand me in both #477 and #479.
What im saying is and that the channelId parsed from the get_artist response is the wrong one so if used again in with get_artist no songs are returned, as the links clearly shows.

sorry for trying to help, I wont make more issues.

[sigma67]

You know you can just reopen the issue or comment below.

If you followed the issue template it would be much easier to reproduce your issue. Here it is again:

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

Additional context
Add any other context about the problem here, such as a code sample.

[Schtenk]

Tried to comment but for some reason I couldn't.
It isn't necessarily a bug depending on what channel id you want, which is why I didn't create a bug report specifically.

I just wanted to point out based on the comment in the code:
if 'musicShelfRenderer' in results[0]: # API sometimes does not return songs in mixin/browsing.py row:235
that using the channelId saved in the code:
artist['channelId'] = subscription_button['channelId'] in in mixin/browsing.py row:224
with get_artist will not return any songs, and that it may be the answer why the issue the comment refers to happens.

[sigma67]

I mean yes, I guess this is a valid issue.

On the other hand, when you're calling get_artist you already have the channelBrowseId. So isn't it more useful to return the channelId from the subscribeButton in that case?

[Schtenk]

Sure, may just be a naming/documentation issue where both are called channelId. It should rarely be a problem but if a user saves the subscribe one for later thinking they are the same, may then lead to the issue occuring.

Only the channelId under the subscribe button can be used for subscribing if i remember correctly, so it is usefull.

[sigma67]

Renaming the key is difficult since it would break backwards compatibility. In light of this subscriptionChannelId would be the better name. I think we can add it to the docstring?