Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core/toast): timer on hover #537

Merged
merged 1 commit into from
May 22, 2023
Merged

fix(core/toast): timer on hover #537

merged 1 commit into from
May 22, 2023

Conversation

goncalosard
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

GitHub Issue Number: #455

What is the new behavior?

  • When hovered, timer stops
  • Stopping hover makes timer resume at the exact time where it stopped.

Does this introduce a breaking change?

  • Yes
  • No

Testing

Other information

@danielleroux danielleroux merged commit df4f168 into main May 22, 2023
@danielleroux danielleroux deleted the fix/toast-hover branch May 22, 2023 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Toast: timer is missing on hover + disappears very fast after hovering (+ starting from 100%)
2 participants