Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IxMenu] Dynamically added menu items will be inserted into wrong DOM node #506

Closed
robert-wettstaedt opened this issue May 3, 2023 · 1 comment · Fixed by #592
Closed
Labels
type: bug Something isn't working
Milestone

Comments

@robert-wettstaedt
Copy link
Contributor

What happened?

After the initial render of the IxMenu I want to dynamically add menu items. Doing so will not insert the new menu items in the correct DOM node so the menu items are overlapping.

Steps to reproduce with the example below:

  • Open the sidebar and verify that you only see the "Home" and "Example" menu items.
  • Close the sidebar
  • Click the "Add 1 menu item" button
  • Open the sidebar and see that the new menu item got inserted into the wrong node

Interestingly, this only occurs when a menu item with the home prop is present. Removing the home prop of the "Home" menu item will result in a working example.

What type of frontend frameware are you seeing the problem on?

React

Which version of iX do you use?

1.4.2

Code to produce this issue.

https://codesandbox.io/s/dynamically-adding-menu-items-will-be-inserted-into-wrong-dom-node-7wtvd7
@robert-wettstaedt robert-wettstaedt added the triage We discuss this topic in our internal weekly label May 3, 2023
@robert-wettstaedt robert-wettstaedt changed the title [IxMenu] Dynamically adding menu items will be inserted into wrong DOM node [IxMenu] Dynamically added menu items will be inserted into wrong DOM node May 3, 2023
@danielleroux danielleroux added type: bug Something isn't working component: core and removed triage We discuss this topic in our internal weekly labels May 4, 2023
@danielleroux danielleroux added this to the 1.6.0 milestone May 4, 2023
@danielleroux
Copy link
Collaborator

Fill be fixed with #511

@danielleroux danielleroux modified the milestones: 1.6.0, 1.7.0 May 25, 2023
@danielleroux danielleroux modified the milestones: 1.7.0, 2.0.0 Jun 27, 2023
@danielleroux danielleroux linked a pull request Jun 27, 2023 that will close this issue
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants