Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate infection/infection to improve tests quality #10

Merged
merged 7 commits into from
May 30, 2023
Merged

Integrate infection/infection to improve tests quality #10

merged 7 commits into from
May 30, 2023

Conversation

maks-rafalko
Copy link
Contributor

@maks-rafalko maks-rafalko commented May 23, 2023 •
edited
Loading

Depends on #7 and #8

Currently in Draft, to trigger CI and see if it works in some way.

  • Check if CI is correctly triggered
  • Fix all the escaped mutants
  • Discuss if we need to create a separate mt.yaml to run it only for one PHP version

maks-rafalko
maks-rafalko commented May 23, 2023
View reviewed changes
.github/workflows/ci.yaml Outdated

- name: Run Infection
shell: bash
run: make infection

This comment was marked as resolved.

Sign in to view

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@sidz
Copy link
Owner

sidz commented May 30, 2023

Could you please rebase against latest master and resolve conflicts?

@maks-rafalko maks-rafalko force-pushed the feature/infection branch 2 times, most recently from cf3d831 to 93dca13 Compare May 30, 2023 18:53
@maks-rafalko maks-rafalko marked this pull request as ready for review May 30, 2023 20:54
sidz
sidz approved these changes May 30, 2023
View reviewed changes
Copy link
Owner

@sidz sidz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@maks-rafalko
Copy link
Contributor Author

@sidz ready for review

Here you can see Infection takes almost 2m when executed for the whole project: https://github.com/sidz/phpstan-rules/actions/runs/5126088310/jobs/9220118095#step:9:1

After running it for the changed lines only, it takes 1s (for this particular PR because no source files are changed): https://github.com/sidz/phpstan-rules/actions/runs/5126162099/jobs/9220300054#step:9:1

But anyway, this is a good improvement.

Regarding MSI, it's now 100%

@sidz
Copy link
Owner

sidz commented May 30, 2023

Discuss if we need to create a separate mt.yaml to run it only for one PHP version

Fine for me to leave it as is.

@sidz sidz merged commit 8cad0d2 into sidz:main May 30, 2023
@sidz
Copy link
Owner

sidz commented May 30, 2023

Thank you @maks-rafalko

@maks-rafalko maks-rafalko deleted the feature/infection branch May 30, 2023 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidz sidz sidz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maks-rafalko @sidz