fix(types): correct TypeCast's Next callback to return unknown #3129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes typeCast Next type appears to be incorrect sidorares#3122
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3129 +/- ##
=======================================
Coverage 88.13% 88.13%
=======================================
Files 71 71
Lines 12890 12890
Branches 1355 1355
=======================================
Hits 11361 11361
Misses 1529 1529
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
wellwelwel
requested changes
Oct 18, 2024
There was a problem hiding this comment.
Thanks, @bbugh.
I've suggested some rollback changes to the website's test files, or if you prefer, the CI error is due to the last EOL character in ./website/test/fixtures/external-code-embed/QueryOptions.txt 🤝
|
@wellwelwel I reverted the fixture files, it appears to be passing the checks now. Sorry for the trouble! |
wellwelwel
approved these changes
Oct 31, 2024
|
Thanks again, @bbugh 🙋🏻♂️ |
This was referenced Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes "typeCast Next type appears to be incorrect" #3122
Also replaced references to the old incorrect type signature in referencing comments