diff --git a/core/package.json b/core/package.json index ff0e62705..21b82e7c6 100644 --- a/core/package.json +++ b/core/package.json @@ -9,7 +9,7 @@ "start": "node .", "test": "npx hardhat test --network testnetwork --config local.hardhat.config.ts", "lint": "eslint --ext \".js,.ts\" --ignore-path .gitignore . --max-warnings=0", - "hardhat:silent": "npx hardhat node 1>&/dev/null", + "hardhat:silent": "npx hardhat node &> /dev/null", "hardhat": "npx hardhat node", "hardhat:simulations": "npx hardhat --network testnetwork --config local.hardhat.config.ts run ./simulations/index.ts", "simulate": "npm-run-all --parallel hardhat:silent hardhat:simulations" diff --git a/core/src/surplus.ts b/core/src/surplus.ts index 1958d73df..15ea8499c 100644 --- a/core/src/surplus.ts +++ b/core/src/surplus.ts @@ -205,11 +205,17 @@ export const enrichSurplusAuction = async ( network: string, auction: SurplusAuctionActive ): Promise => { - const nextMinimumBid = await getNextMinimumBid(network, auction); + let nextMinimumBid = await getNextMinimumBid(network, auction); const unitPrice = auction.bidAmountMKR.div(auction.receiveAmountDAI); - const marketUnitPrice = await getMarketPriceMkr(network, auction.bidAmountMKR); + let marketUnitPrice = await getMarketPriceMkr(network, auction.bidAmountMKR); const marketUnitPriceToUnitPriceRatio = unitPrice.minus(marketUnitPrice).dividedBy(marketUnitPrice); const fees = await getSurplusTransactionFees(network); + if (nextMinimumBid.isZero()) { + nextMinimumBid = new BigNumber(1000).plus(fees.combinedBidFeesDai).div(marketUnitPrice); + } + if (marketUnitPrice.isNaN()) { + marketUnitPrice = await convertMkrToDai(network, new BigNumber(1)); + } return { ...auction, ...fees, diff --git a/frontend/components/auction/surplus/SurplusAuction.vue b/frontend/components/auction/surplus/SurplusAuction.vue index 28486f55e..e050efb46 100644 --- a/frontend/components/auction/surplus/SurplusAuction.vue +++ b/frontend/components/auction/surplus/SurplusAuction.vue @@ -27,14 +27,7 @@ Auction State - Ends in - Requires restart - Ended - Collected - + @@ -148,6 +141,7 @@ import Vue from 'vue'; import type { CompensationAuctionActionStates, SurplusAuctionTransaction } from 'auctions-core/src/types'; import { Alert, Tooltip } from 'ant-design-vue'; +import SurplusAuctionState from '~/components/auction/surplus/SurplusAuctionState.vue'; import TextBlock from '~/components/common/other/TextBlock.vue'; import TimeTill from '~/components/common/formatters/TimeTill.vue'; import Button from '~/components/common/inputs/BaseButton.vue'; @@ -161,6 +155,7 @@ export default Vue.extend({ name: 'SurplusAuction', components: { AuctionRestartPanel, + SurplusAuctionState, FormatCurrency, TextBlock, TimeTill, diff --git a/frontend/components/auction/surplus/SurplusAuctionBidTransactionTable.vue b/frontend/components/auction/surplus/SurplusAuctionBidTransactionTable.vue index 251356cb6..3e0a04e3c 100644 --- a/frontend/components/auction/surplus/SurplusAuctionBidTransactionTable.vue +++ b/frontend/components/auction/surplus/SurplusAuctionBidTransactionTable.vue @@ -3,7 +3,7 @@
Auction State
- +
@@ -57,7 +57,7 @@
Price on Uniswap
-
Price after the bid
- diff --git a/frontend/components/auction/surplus/SurplusAuctionTransactionFlow.vue b/frontend/components/auction/surplus/SurplusAuctionTransactionFlow.vue index d57668423..896a9cd0d 100644 --- a/frontend/components/auction/surplus/SurplusAuctionTransactionFlow.vue +++ b/frontend/components/auction/surplus/SurplusAuctionTransactionFlow.vue @@ -84,7 +84,7 @@