Add CurveLpTokenUniv3Callee callee support

[valiafetisov]

Goal

Support new SteCRV collateral

Prerequisite

• CurveLpTokenUniv3Callee callee PR is merged
  • done
• Callee is deployed at least on the mainnet
  • done https://etherscan.io/address/0x71f2198849f3b1372ea90c079bd634928583f2d2
• Related addresses (token address, clip address, etc) become part of the chainlog
  • done CRVV1ETHSTETH
• At least one auction of this collateral type is executed on the mainnet (or we have another way to test it)
  • see MCD_CLIP_CRVV1ETHSTETH_A events

Context

New collateral types are coming and we need to add support for them. This time it can be a bit more difficult, since we don't have yet reference implementation of the auction-demo-keeper. There is a PR that implements auction-demo-keeper support for this callee: makerdao/auction-demo-keeper#60, main price fetching logic is within this block.

Tasks

• Investigate callee implementation to document needed conversions
• Implement callee functions, according to the Collateral onboarding guide
• Test

[LukSteib]

CurveLpTokenUniv3Callee callee PR is merged

It is deployed: https://etherscan.io/address/0x71f2198849f3b1372ea90c079bd634928583f2d2

Related addresses (token address, clip address, etc) become part of the chainlog

They are now: Searching chainlog for CRVV1ETHSTETH

[valiafetisov]

What about testing strategy for the callee? Would there be at least one auction on the mainnet?

[LukSteib]

What about testing strategy for the callee? Would there be at least one auction on the mainnet?

Current status:

• no vault for the collateral type in existence on mainnet for now (checked via https://maker.blockanalitica.com/vaults/)
• not possible to create a vault via UI for now (checked via https://oasis.app/)
• reached out to PE to ask about existence of test vault / auction (answer pending)

[LukSteib]

Update:

• it is now possible to create vaults with CRVV1ETHSTETH as collateral
• 5 vaults exist already
  • I assume chaoslabs should be able to simulate a liquidation for this collateral type based on their existing approach

[valiafetisov]

I assume chaoslabs should be able to simulate a liquidation for this collateral type based on their existing approach

Not really. Update from the chaoslabs:

We located 6 CRVV1ETHSTETH-A vaults but they all appear in inactive state (no debt) and hence are not elegible for liquidations (even when simulating price drops).
We will work on implementing the support for creating active vaults for a given collateral type but it is a larger engineering lift and will take more time on our side.
If you have active vault ids that you can share with us we will be able to create a simulation quickly (~couple of hours).

[LukSteib]

Not good news.
I don't get the differentiation between active and inactive vaults tbh. The vault analytics (see below) show that the vaults associated to CRVV1ETHSTETH-A do have debt. However they seem to be different due to a) the vault ID doesn't follow the usual pattern b) there seems to be no Dai borrowed for these vaults c) no user wallet is associated with these vaults

https://maker.blockanalitica.com/vaults/CRVV1ETHSTETH-A/

[valiafetisov]

no Dai borrowed for these vaults

Thanks for the link! Although I am not sure I understand how there can be a debt if no DAI was withdrawn? But yeah, I think this what they're referencing to: if no DAI was withdrawn, changing oracle price wouldn't make them "kickable"