Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Twitter Message #209

Closed
wants to merge 1 commit into from
Closed

Updated Twitter Message #209

wants to merge 1 commit into from

Conversation

zoey-kaiser
Copy link
Contributor

closes #87

I don't know if this PR/Issue are really needed, as I took it from the backlog. But as it was such a simple change I decided to take care of it.

This PR just changes the Tweet message to include a $ before the currency type.

@LukSteib
Copy link
Contributor

I would like to test it via our staging bot before approving to see whether the tweet is rendered correctly. But as it doesn't have prio right now, postponed for now

@zoey-kaiser zoey-kaiser marked this pull request as draft April 20, 2022 06:59
@LukSteib
Copy link
Contributor

@benediktkaiser
Since we do have a bot and bot-twitter folder now I am not sure where to create the .env with relevant twitter env variables. Do we need one general .env file in bot folder from now on for both keeper and twitter bot or two separate ones.

@zoey-kaiser
Copy link
Contributor Author

@benediktkaiser Since we do have a bot and bot-twitter folder now I am not sure where to create the .env with relevant twitter env variables. Do we need one general .env file in bot folder from now on for both keeper and twitter bot or two separate ones.

twitter-bot should not be used at all anymore. It no longer exists (and if it does, it won't be used for anything). Please only change the variables in /bot. The secrets has also been updated, we used ENVIORNMENT/auctions-ui/bot.

@LukSteib
Copy link
Contributor

Closed for now - we won't go with the $ sign for now. Might be re-opened at some later point

@LukSteib LukSteib closed this May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add $ sign to twitter bot message
2 participants