Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop fetching data through wallet #65

Closed
4 tasks done
Tracked by #72
valiafetisov opened this issue Jan 27, 2022 · 1 comment
Closed
4 tasks done
Tracked by #72

Stop fetching data through wallet #65

valiafetisov opened this issue Jan 27, 2022 · 1 comment

Comments

@valiafetisov
Copy link
Contributor

valiafetisov commented Jan 27, 2022

Goal

Stop fetching data through Metamask, use it only for signing write operations

Context

Since Metamask started to apply rate limiting, frontend sometimes hits the limit due to the high number of requests that we have to make. The only downside of that is increased our infura usage, which will be mitigated in #38.

The proposed solution is to have two separate providers:

  1. The provider created with our infura endpoint
  2. The signer created with wallet signer
    Therefore, it should be possible to getContracts by specifying which provider to use, possibly just adding extra argument withSigner, with false by default.

Tasks

  • Store providers and signers separately
  • Extend getContract function
  • Validate that after connecting wallet read calls are still go through our endpoint
  • Validate that wallet functionality is not affected
This was referenced Jan 27, 2022
@valiafetisov
Copy link
Contributor Author

This issue was closed as part of the PR #74

@LukSteib LukSteib mentioned this issue Feb 14, 2022
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant