Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly update net profit indicator panel #564

Closed
1 task
LukSteib opened this issue Dec 7, 2022 · 0 comments · Fixed by #566
Closed
1 task

Properly update net profit indicator panel #564

LukSteib opened this issue Dec 7, 2022 · 0 comments · Fixed by #566

Comments

@LukSteib
Copy link
Contributor

LukSteib commented Dec 7, 2022

Goal

The net profit indicator panel is in sync with callee selection

Context

After introducing multi callee support it seems like the net profit check panel is no longer properly kept in sync.
Description of problem that we've experienced:

  • Select callee (e.g auto router) that yields a positive net profit (net profit check panel green as it should be)
  • Switchting to another less optimal callee that yields negative net profit (net profit check panel doesn't update accordingly but stays green)

See recording in asset section

Assets

2022-12-06.15-53-23.mp4

Tasks

  • Fix described problem above and ensure that net profit check panel always is in correct state
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant