Discuss time till profitability

[LukSteib]

Goal

Callee selection affects time till profitability

Context

We have introduced multi callee support that allows a user to select between different exchange callees. These come with different market price.
So ultimately one can expect that the "Time till profitability" indicator would need to change based on the callee selection.
Currently unsure whether we take this into account.
If the market prices of different callees only slightly differ chances are high that auction price will drop below all with the same price drop step.
However if prices of different callees differ quite a lot the time till profitability might also be different since the thresholds won't be reached with the same price drop

Let's use this issue to discuss whether the assumption above is correct and if so how to address

Tasks

• Discuss effect of callee selection on "Time till profitability"
• (if needed)Outline approach for adjustment
• (if needed) Implement adjustment

[valiafetisov]

As far as I remember Time till profitability is already computed per callee. But not sure it the correct one is displayed. @aomafarag can you please confirm that with links to the source code (lines where it's computed per callee and lines where it is changed based on the selected callee) or outline what needs to be changed?

[aomafarag]

As far as I remember Time till profitability is already computed per callee.

Yes, it is. When enriching the auction, we calculate transactionGrossProfitDate for each callee.

[valiafetisov]

and lines where it is changed based on the selected callee

What about this question? It is currently calculated, but not changed on the frontend?

[aomafarag]

and lines where it is changed based on the selected callee

What about this question? It is currently calculated, but not changed on the frontend?

OK, I just checked. It is not updated on the frontend because the TimeTillProfitable component takes the whole auctionTransaction object as a prop, not just the transactionGrossProfitDate (check this).

What we need to do is just pass the transactionGrossProfitDate of the selected callee instead of the whole object and the issue would be resolved.