-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement vault liquidation service #466
Comments
I would suggest (since this was not mentioned before) to use
I would suggest extracting this into another PR
the frontend should nevertheless have missing functionality - right? (the vaults table will not be populated) what about the functionality to continiously keep the database up-to-date? Is it going to be a different issue's scope? |
I would suggest to use I would also suggest to use What would you suggest to use to build/package and develop it with? tsup? Something better that uses
It's expected to be covered by this issue.
I guess frontend integration can be moved to yet another issue. General idea: if endpoints are down, the frontend should have missing functionality, but not broken state. For example, if started locally (via isDev kind-of check) frontend can signal that the service is not running. In production it should say that endpoints are down and that specific vault ids can be used to liquidate them + point user to some other UI/way to get vaults at risk. |
No further questions about the rest of the topics. Should i propose the service structure in more detail compared with the linked in |
If you have any questions / unsure about structure or already have it in the notes and want to document it. For me the general structure doesn't raise any questions, I'm only unsure about enrichment and when/how it is triggered. Compared to the events that we could've subscribe to, now we would now need to refetch it periodically or parse every block (depending on what takes less resources). What's the approach here? |
Important terminology: in the answer for this q:
General scope:
Proposal
Minmalistic types then are: interface SearchableEvent {
contractName: string;
eventName: string;
loggedValues: string[];
}
interface SearchableFunctionCall {
topicSignatrue: string[];
topicIndexToArgumentName: Record<number, string>;
dataIndexToArgumentName?: Record<number, string>;
} We want to react to:
|
Goal
PM is able to start a service, understand when its update is complete and fetch list of vaults at risk
Context
After the conclusion of the related investigation issue, where the implementation proposal was outlined, and implementation of the core logic we need to implement the backend service that keeps track of the vaults and determines which of them are at risk. Please use this issue to discuss implementation details.
Assets
Tasks
The text was updated successfully, but these errors were encountered: