Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Bidding with DAI the amount to receive logic #165

Closed
5 tasks done
valiafetisov opened this issue Mar 29, 2022 · 0 comments · Fixed by #167
Closed
5 tasks done

Update Bidding with DAI the amount to receive logic #165

valiafetisov opened this issue Mar 29, 2022 · 0 comments · Fixed by #167

Comments

@valiafetisov
Copy link
Contributor

valiafetisov commented Mar 29, 2022

Goal

Fixed amount to receive indication in the BidTransactionTable

Context

After executing first Bid with DAI transaction, we realised that the user doesn't receive the whole amount of collateral. More info here: #163 (comment). Based on this, we need to:

  • Create new core function which will calculate actual amount to receive based on the input value
  • Add store logic to fetch collateral in the VAT
  • Add store logic to withdraw collateral from VAT to Wallet

Tasks

  • Implement all the above
  • Provide testing commands in the PR description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant