Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement BidTransaction component #121

Closed
3 tasks
Tracked by #117 ...
valiafetisov opened this issue Feb 28, 2022 · 0 comments · Fixed by #151
Closed
3 tasks
Tracked by #117 ...

Implement BidTransaction component #121

valiafetisov opened this issue Feb 28, 2022 · 0 comments · Fixed by #151
Assignees

Comments

@valiafetisov
Copy link
Contributor

valiafetisov commented Feb 28, 2022

Goal

Implemented BidTransaction component via the AuctionFakeData container

Context

Similar to the SwapTransaction, we need to implement BidTransaction first using stub data. All the underlying component should be ready at this time: AccessDaiBlock, DepositBlock, BidBlock, BidTransactionTable.

Note that Bid with DAI button should stay disabled in this issue as it will be implemented later.

Assets

Tasks

  • create new BidTransaction inside transaction folder
  • please handle isFinished and isActive states properly (reuse error handling from another transaction component)
  • the flow should be testable in AuctionFakeData or the storybook
@fegbert fegbert self-assigned this Mar 1, 2022
@LukSteib LukSteib mentioned this issue Mar 14, 2022
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants