Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential DIDComm did:peer:2 Spec Compliance Issue #130

Open
TheTechmage opened this issue Oct 11, 2023 · 0 comments
Open

Potential DIDComm did:peer:2 Spec Compliance Issue #130

TheTechmage opened this issue Oct 11, 2023 · 0 comments

Comments

@TheTechmage
Copy link

TheTechmage commented Oct 11, 2023

I'm not too familiar with how the DIDPeer DIDs are supposed to work, but according to this comment, it appears that there may be some issues with Peer DID Numalgo 2 generation across libraries between https://github.com/sicpa-dlab/didcomm-python/ and here. The output is different enough that it has caused a conversion layer to be built to convert the DID between libraries in order to maintain inter-operability. Daniel has submitted a PR to the Spec to make clarifications decentralized-identity/peer-did-method-spec#62 but as of this moment it has not been merged.

Irregardless of the merge status, did:peer:2 DIDs generated by didcomm-rust and didcomm-python are incompatible with each-other when a service endpoint is defined. didcomm-python is expecting a flat servicesEndpoint structure, where-as didcomm-rust is expecting an object.

cc: @dbluhm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant