Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create rule+tests to lint/format annotations for members/types #303

Merged
merged 2 commits into from
Oct 26, 2018

Conversation

cable729
Copy link
Contributor

Fixes #258

For reviewers to double-check:

  • Are there any tests I'm missing? I feel like there are probably some more obtuse/strange ways annotations can be placed

@shyiko
Copy link
Collaborator

shyiko commented Oct 26, 2018

Thank you for the PR, Caleb! It looks really, really good. The only other thing I would check would be how it behaves when annotations have arguments spread over multiple lines, e.g.

@JvmField @Volatile @Annotation(
    enabled = true,
    groups = [
        "a",
        "b",
        "c"
    ]
)

@shyiko
Copy link
Collaborator

shyiko commented Oct 26, 2018

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants