This repository has been archived by the owner on Feb 16, 2024. It is now read-only.
Add tests #2
Merged
Add tests #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
recurser
force-pushed
the
dave/ch69519/add-tests
branch
3 times, most recently
from
e8ba808 to
877214f
Compare
recurser
commented
Aug 31, 2020
| message: data&.to_json, | ||
| }.compact | ||
| end | ||
|
|
There was a problem hiding this comment.
Just putting methods in alphabetical order - no logic changes.
recurser
force-pushed
the
dave/ch69519/add-tests
branch
from
877214f to
078124e
Compare
recurser
requested review from
adamazing,
avokhmin,
sbusso and
VaguelyElectric
VaguelyElectric
approved these changes
Sep 1, 2020
avokhmin
reviewed
Sep 1, 2020
lib/trailer/concern.rb
Outdated
| @@ -27,7 +28,7 @@ def trace_event(event, resource = nil, **tags, &block) # rubocop:disable Metrics | |||
| end | |||
| elsif resource.respond_to?(:to_h) | |||
| # This handles other types of data, such as GraphQL input objects. | |||
| resource.to_h.stringify_keys.each do |key, value| | |||
| resource.to_h.transform_keys(&:to_s).each do |key, value| | |||
| tags[key] ||= value if key.to_s.match?(Trailer.config.auto_tag_fields) || Trailer.config.tag_fields.include?(key) | |||
There was a problem hiding this comment.
Suggested change
| tags[key] ||= value if key.to_s.match?(Trailer.config.auto_tag_fields) || Trailer.config.tag_fields.include?(key) | |
| tags[key] ||= value if key.match?(Trailer.config.auto_tag_fields) || Trailer.config.tag_fields.include?(key) |
There was a problem hiding this comment.
PS: maybe here better to use a symbols too?
avokhmin
reviewed
Sep 3, 2020
| # | ||
| # @param data [Hash] A key-value hash of trace data to write to storage. | ||
| def write(data) | ||
| return if data.empty? |
There was a problem hiding this comment.
maybe:
def write(data)
return if data.nil? || data.empty?
messages << {
timestamp: (Time.now.utc.to_f.round(3) * 1000).to_i,
message: data.to_json,
}
end
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests
Clubhouse Story
How to test the PR
If tests pass, it works.
Deployment Notes
None.