Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Failed compilation on stable rustc 1.70.0 #965

Closed
1 task done
toksdotdev opened this issue Jun 2, 2023 · 3 comments
Closed
1 task done

[Bug]: Failed compilation on stable rustc 1.70.0 #965

toksdotdev opened this issue Jun 2, 2023 · 3 comments
Labels
T-Bug Something isn't working

Comments

@toksdotdev
Copy link

What happened?

Installing shuttle on the most recent version of stable Rust (1.70.0) fails. I've attached a copy of the logs alongside this issue.

Version

v0.17.0

Which operating system(s) are you seeing the problem on?

macOS

Which CPU architectures are you seeing the problem on?

ARM64

Relevant log output

error[E0308]: mismatched types
  --> /Users/toks/.cargo/registry/src/index.crates.io-6f17d22bba15001f/shuttle-common-0.17.0/src/models/error.rs:27:43
   |
27 |             self.message.to_string().with(Color::Red)
   |                                      ---- ^^^^^^^^^^ expected `crossterm::style::Color`, found `comfy_table::Color`
   |                                      |
   |                                      arguments to this method are incorrect
   |
   = note: `comfy_table::Color` and `crossterm::style::Color` have similar names, but are actually distinct types
note: `comfy_table::Color` is defined in crate `crossterm`
  --> /Users/toks/.cargo/registry/src/index.crates.io-6f17d22bba15001f/crossterm-0.26.1/src/style/types/color.rs:28:1
   |
28 | pub enum Color {
   | ^^^^^^^^^^^^^^
note: `crossterm::style::Color` is defined in crate `crossterm`
  --> /Users/toks/.cargo/registry/src/index.crates.io-6f17d22bba15001f/crossterm-0.25.0/src/style/types/color.rs:28:1
   |
28 | pub enum Color {
   | ^^^^^^^^^^^^^^
   = note: perhaps two different versions of crate `crossterm` are being used?
note: method defined here
  --> /Users/toks/.cargo/registry/src/index.crates.io-6f17d22bba15001f/crossterm-0.25.0/src/style/stylize.rs:78:8
   |
78 |     fn with(self, color: Color) -> Self::Styled {
   |        ^^^^

error[E0308]: mismatched types
  --> /Users/toks/.cargo/registry/src/index.crates.io-6f17d22bba15001f/shuttle-common-0.17.0/src/models/service.rs:45:27
   |
45 |                     .with(deployment.state.get_color()),
   |                      ---- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected `crossterm::style::Color`, found `comfy_table::Color`
   |                      |
   |                      arguments to this method are incorrect
   |
   = note: `comfy_table::Color` and `crossterm::style::Color` have similar names, but are actually distinct types
note: `comfy_table::Color` is defined in crate `crossterm`
  --> /Users/toks/.cargo/registry/src/index.crates.io-6f17d22bba15001f/crossterm-0.26.1/src/style/types/color.rs:28:1
   |
28 | pub enum Color {
   | ^^^^^^^^^^^^^^
note: `crossterm::style::Color` is defined in crate `crossterm`
  --> /Users/toks/.cargo/registry/src/index.crates.io-6f17d22bba15001f/crossterm-0.25.0/src/style/types/color.rs:28:1
   |
28 | pub enum Color {
   | ^^^^^^^^^^^^^^
   = note: perhaps two different versions of crate `crossterm` are being used?
note: method defined here
  --> /Users/toks/.cargo/registry/src/index.crates.io-6f17d22bba15001f/crossterm-0.25.0/src/style/stylize.rs:78:8
   |
78 |     fn with(self, color: Color) -> Self::Styled {
   |        ^^^^

For more information about this error, try `rustc --explain E0308`.

Duplicate declaration

  • I have searched the issues and there are none like this.
@toksdotdev toksdotdev added the T-Bug Something isn't working label Jun 2, 2023
@oddgrd
Copy link
Contributor

oddgrd commented Jun 2, 2023

Hey! This has been resolved in #961, but the fix won't be released until monday. Until then you can work around this by running cargo install cargo-shuttle --locked, or you can use binstall. Apologies for the lack of visibility on this though, so thanks for opening this issue, we'll leave it up until release!

@iamwacko
Copy link
Contributor

iamwacko commented Jun 5, 2023

The new release is out now, but maybe we should consider adding --locked to the install instructions in the README.

@jonaro00
Copy link
Member

Adding the --locked hint in #989

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants