Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: use sudo to run docker #848

Open
1 task done
paulotten opened this issue May 2, 2023 · 3 comments
Open
1 task done

[Feature]: use sudo to run docker #848

paulotten opened this issue May 2, 2023 · 3 comments
Labels
S-Not Planned We don't have any plans to work on this T-Improvement Improvement or addition to existing features

Comments

@paulotten
Copy link
Contributor

Describe the feature

The current Makefile assumes that the current user can run docker. This is only possible if the user is added to the docker group, which allows escalation to root privilages.

From https://wiki.archlinux.org/title/docker#Installation:

Warning: Anyone added to the docker group is root equivalent because they can use the docker run --privileged command to start containers with root privileges. For more information see [3] and [4].

Instead the Makefile should use sudo.

Suggestion or Example of how the feature would be used

No response

Duplicate declaration

  • I have searched the issues and this feature has not been requested before.
@oddgrd
Copy link
Contributor

oddgrd commented May 11, 2023

Thanks! I suppose it would be good to not force contributors to add their user to the docker group to contribute to shuttle. What do you think about this @iulianbarbu?

@iulianbarbu
Copy link
Contributor

This is only possible if the user is added to the docker group, which allows escalation to root privilages.

There is also this docker mode of operation https://docs.docker.com/engine/security/rootless/ and it would be great to know how to run our Makefile in this mode.

Would be great to assess what commands from the Makefile need sudo and why, but using sudo instead of docker group approach would be welcomed.

@oddgrd
Copy link
Contributor

oddgrd commented May 11, 2023

I believe it's possible to develop shuttle in rootless mode using podman, but I haven't tried it out myself. If we could do it in docker too that would be cool, yeah!

@jonaro00 jonaro00 added T-Improvement Improvement or addition to existing features S-Not Planned We don't have any plans to work on this labels Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-Not Planned We don't have any plans to work on this T-Improvement Improvement or addition to existing features
Projects
None yet
Development

No branches or pull requests

4 participants