feat: ensure interactive login API key is valid format #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On second thought, this will break the flow of setting a jwt as apikey for local deployer runs. I may scope this down to validating the login input. 🤔 |
oddgrd
changed the title
oddgrd
commented
Apr 18, 2023
oddgrd
added a commit
that referenced
this pull request
Apr 27, 2023
* feat: ensure API key is valid * revert: scope down to validating interactive login
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This creates a newtype for the api-key on the client side, so we can maintain that it is always a valid api-key. We should extend this type to also be usable in theScoped down to validating interactive login, see comment.authcrate in the future.Closes #779
How Has This Been Tested (if applicable)?
Tested logging in interactively with valid and invalid keys (for example from an invalid paste command).