-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for resource deletion #615
Comments
Hey, I think I can try to tackle this! I have an initial question though:
Looking at the schema in |
For whoever is stumbling upon this, #622 implemented the required provisioner changes, but left out the needed deployer and client-side changes. |
@MrCoolTheCucumber Is it cool with you if I take the remaining work here? Do you have any info or WIP to share before I do? |
Yeah of course you can! I started writing the handler but found it hard figuring out how exactly to call the RPC method within the handler. I dont think I have the changes stashed anymore though unfortunately. |
Currently there is no way to delete a resource attached to a deployment (such as a database that was provisioned from an annotation to the
shuttle_service::main
function). We'd like to expose such functionality so that resources attached to services can be removed imperatively from the CLI with a command such ascargo shuttle resource delete {resource-name}
.For this we need a change to provisioner to write the deletion logic and expose the methjod through gRPC, then a change to deployer to write the deletion logic (calling provisioner) and checking for the sanity of the operation (is a running service using it?) and expose the API through handlers, and then finally a change to cargo-shuttle which exposes the command to the CLI.
The text was updated successfully, but these errors were encountered: