Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tempdir #603

Merged
merged 12 commits into from
Feb 8, 2023
Merged

Tempdir #603

merged 12 commits into from
Feb 8, 2023

Conversation

gautamprikshit1
Copy link
Contributor

Worked on #598

chesedo
chesedo approved these changes Jan 27, 2023
View reviewed changes
Copy link
Contributor

@chesedo chesedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for this @gautamprikshit1

@chesedo
Copy link
Contributor

chesedo commented Jan 27, 2023

Just have to check the failing test @gautamprikshit1

oddgrd
oddgrd approved these changes Feb 8, 2023
View reviewed changes
Copy link
Contributor

@oddgrd oddgrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Just one final comment.

@oddgrd oddgrd merged commit ec5183b into shuttle-hq:main Feb 8, 2023
@oddgrd oddgrd mentioned this pull request Feb 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chesedo chesedo chesedo approved these changes

@oddgrd oddgrd oddgrd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gautamprikshit1 @chesedo @oddgrd