Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: postgres example #31

Merged
merged 48 commits into from
Mar 13, 2022
Merged

feat: postgres example #31

merged 48 commits into from
Mar 13, 2022

Conversation

chesedo
Copy link
Contributor

@chesedo chesedo commented Mar 3, 2022

A working example and e2e test for connecting to postgres

@brokad brokad force-pushed the tests/postgres branch 2 times, most recently from 2790b6f to 95b28ec Compare March 6, 2022 20:32
@brokad
Copy link
Collaborator

brokad commented Mar 6, 2022

I've added a couple features for making this easier to track:

  • Randomized port attributions so that tests can run in //
  • The postgres test runs with the api docker image (this will make it pick up hygiene issues easier)
  • Capture of the stdout/stderr of spawned things along with prefixing and color differences for tracking it all

AFAICT, the tests fail for two reasons:

  • The users.toml path is brittle, and does not exist in the docker container
  • The unveil-service version mismatch (between crates.io and local) which causes the example to build locally, but not server-side

Then:

  • The tests may still fail in CI if we don't add the corresponding dummy auth tokens while they run there

@brokad brokad marked this pull request as ready for review March 6, 2022 20:43
@brokad brokad self-requested a review March 6, 2022 20:46
@christos-h christos-h mentioned this pull request Mar 10, 2022
4 tasks
Copy link
Collaborator

@brokad brokad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chesedo legend

@brokad brokad merged commit bba246d into main Mar 13, 2022
@chesedo chesedo deleted the tests/postgres branch March 14, 2022 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants