feature: check shuttle service version before deploy #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use process command to get cargo tree response and parse the shuttle-service version
- While the deploy process happen, we get the version from API and compare with current shuttle-service version
marioidival
force-pushed
the
feature/check-server-version
branch
from
dbc41ec to
a7d0af9
Compare
chesedo
reviewed
Jun 6, 2022
There was a problem hiding this comment.
@marioidival this is looking great!! I mostly have questions on small things
marioidival
force-pushed
the
feature/check-server-version
branch
from
1dda23b to
54479a3
Compare
chesedo
reviewed
Jun 7, 2022
chesedo
approved these changes
Jun 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Approach:
The idea is given to all users an endpoint to get the current version of shuttle-service used by the API, then the clients just can make a call on this endpoint and see the current version.