Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement]: bump sqlx to 0.8.2 #1863

Closed
1 task done
nicolasauler opened this issue Aug 23, 2024 · 7 comments
Closed
1 task done

[Improvement]: bump sqlx to 0.8.2 #1863

nicolasauler opened this issue Aug 23, 2024 · 7 comments
Labels
S-Accepted This will be worked on T-Improvement Improvement or addition to existing features

Comments

@nicolasauler
Copy link

nicolasauler commented Aug 23, 2024

Describe the improvement

This will allow consumers of the crate to update to the latest sqlx.
Also, sqlx <= 0.8.0 has a reported security vulnerability, and the fix is at 0.8.1.

Duplicate declaration

  • I have searched the issues and this improvement has not been requested before.
@nicolasauler nicolasauler added S-Triage Awaiting decision for what to do T-Improvement Improvement or addition to existing features labels Aug 23, 2024
@nicolasauler
Copy link
Author

I'm also onboard for helping solve this issue, as I'm an interested party.
I just never opened a PR on this repo and maybe could use some guidance, although from what I've seen the Contribution and Developing guides are quite thorough.

@jonaro00
Copy link
Member

Thanks for giving attention to this. It's an easy change to make: Bump the version in the shared db and AWS RDS crates, and make sure they compile. After that works, all examples using it can be updated.

@jonaro00
Copy link
Member

I forgot that we already did this in #1847. What we can do now that 0.8.1 is released is to bump it again. There is a bug in 0.8.1 that will make it not compile on Rust < 1.80 which our CI uses, but we can ignore that (just run the CI command locally with 1.80).

@jonaro00 jonaro00 changed the title [Improvement]: bump sqlx to 0.8.0 [Improvement]: bump sqlx to 0.8.1 Aug 26, 2024
@jonaro00 jonaro00 added Good First Issue Good for newcomers Contribution Wanted The community is welcome to collaborate on this issue S-Accepted This will be worked on and removed S-Triage Awaiting decision for what to do labels Aug 26, 2024
@GnomedDev
Copy link

Seems like sqlx dep has already been bumped, and all that is needed is a new breaking release of shuttle-shared-db.

@jonaro00 jonaro00 removed Good First Issue Good for newcomers Contribution Wanted The community is welcome to collaborate on this issue labels Sep 6, 2024
@jonaro00
Copy link
Member

jonaro00 commented Sep 7, 2024

Yep, solved in #1867. Awaiting release.

@nicolasauler nicolasauler changed the title [Improvement]: bump sqlx to 0.8.1 [Improvement]: bump sqlx to 0.8.2 Sep 10, 2024
@joshua-mo-143
Copy link
Member

SQLx has been bumped to 0.8.2 on shuttle-shared-db 0.48.0! You should now be unblocked from this.

@nicolasauler
Copy link
Author

Thanks a lot, my friends!
Closing issue as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-Accepted This will be worked on T-Improvement Improvement or addition to existing features
Projects
None yet
Development

No branches or pull requests

4 participants