feat: generated Permit client, project permission logic #1699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonaro00
force-pushed
the
permit-openapi-client
branch
2 times, most recently
from
f47320e to
8e8ee8c
Compare
jonaro00
changed the title
jonaro00
force-pushed
the
permit-openapi-client
branch
from
fdbd629 to
fab937c
Compare
jonaro00
force-pushed
the
permit-openapi-client
branch
from
fab937c to
1ef4349
Compare
jonaro00
commented
Mar 27, 2024
| @@ -81,7 +83,9 @@ pub async fn sync(pool: PgPool, args: SyncArgs) -> io::Result<()> { | |||
| } | |||
| } | |||
| } | |||
| Err(shuttle_backends::client::Error::RequestError(StatusCode::NOT_FOUND)) => { | |||
| Err(_) => { | |||
| // FIXME: Make the error type better so that this is only done on 404s | |||
iulianbarbu
reviewed
Mar 27, 2024
There was a problem hiding this comment.
The permit client changes and some of the tests are heavy to go through in this review. It is probably best to be reviewed by @chesedo who has more context, but apart from this, left a few qs for now.
| @@ -68,7 +68,9 @@ services: | |||
| - "--stripe-secret-key=${STRIPE_SECRET_KEY}" | |||
| # used only for local development | |||
| - "--jwt-signing-private-key=LS0tLS1CRUdJTiBQUklWQVRFIEtFWS0tLS0tCk1DNENBUUF3QlFZREsyVndCQ0lFSUR5V0ZFYzhKYm05NnA0ZGNLTEwvQWNvVUVsbUF0MVVKSTU4WTc4d1FpWk4KLS0tLS1FTkQgUFJJVkFURSBLRVktLS0tLQo=" | |||
| - "--permit-api=https://api.eu-central-1.permit.io" | |||
| - "--permit-api-uri=https://api.eu-central-1.permit.io" | |||
There was a problem hiding this comment.
I imagine this can differ based on how a Permit account is configured. Makes me think that it is better to hide it behind an env var.
jonaro00
force-pushed
the
permit-openapi-client
branch
from
18d5cad to
0009469
Compare
jonaro00
force-pushed
the
permit-openapi-client
branch
from
0009469 to
02cbccc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Permit logic to the project create+delete actions. This will be released without taking control of permission checking to allow a background migration between releases.
Things for upcoming PRs: