Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fall back to finding Secrets.toml in workspace root #1682

Merged
merged 3 commits into from
Mar 18, 2024

Conversation

jonaro00
Copy link
Member

Description of change

We look for Secret.toml in the crate directory, making placing it in the workspace root a common papercut.
This allows you to do both, with the crate dir taking prio.

How has this been tested? (if applicable)

Tested with local run and local deployment

Copy link
Contributor

@oddgrd oddgrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good thinking! I have one question about the test removal, otherwise LGTM!

@jonaro00 jonaro00 merged commit 6acabb7 into shuttle-hq:main Mar 18, 2024
28 of 30 checks passed
@jonaro00 jonaro00 deleted the secrets-in-root branch March 18, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants