feat(runtime, deployer)!: extract load phase + provisioning to deployer, resource update #1628

jonaro00 · 2024-02-14T13:34:44Z

Description of change

Resource update:

Replaced ResourceBuilder with ResourceConfigBuilder, a new and updated API for writing plugins.

Breaking:

Local run and deploy with outdated runtime will fail.
DeploymentMetadata: removed field service_name. Use field project_name.
These changes have been made compatible with console, only old c-s will break when parsing newer models
- DatabaseResource is now serde untagged
- SecretStore is serde transparent
Old secrets will be invalidated due to being serde untagged (next deploy after upgrade will need fresh secrets file)

How has this been tested? (if applicable)

chesedo

This is taking great shape. Thanks J!!

cargo-shuttle/src/lib.rs

codegen/src/shuttle_main/mod.rs

deployer/src/deployment/run.rs

proto/runtime.proto

resources/qdrant/src/lib.rs

runtime/Cargo.toml

runtime/src/alpha/mod.rs

service/src/lib.rs

iulianbarbu

Looks great @jonaro00 ! This got to be very cool 💪 . Left a few comments, nothing very outstanding.

common/src/lib.rs

common/src/resource.rs

deployer/src/deployment/run.rs

resources/qdrant/src/lib.rs

resources/shared-db/src/postgres.rs

This reverts commit 8c72605.

chesedo

Just some final touches remaining

cargo-shuttle/tests/integration/run.rs

deployer/src/deployment/run.rs

runtime/src/alpha/mod.rs

service/src/lib.rs

cargo-shuttle/src/lib.rs

chesedo

LGTM

…ovisioner

cargo-shuttle/src/lib.rs

examples

.circleci/config.yml

oddgrd

I didn't get through all of it yet, but don't delay merging on my account, I am quite late to the party 😄 I left a few nits/minor comments, but LGTM so far!

codegen/src/shuttle_main/mod.rs

cargo-shuttle/src/provisioner_server.rs

deployer/src/deployment/run.rs

jonaro00 changed the title ~~Deployer runtime provisioner~~ feat(runtime, deployer): load phase extraction, provisioning from deployer Feb 14, 2024

jonaro00 changed the title ~~feat(runtime, deployer): load phase extraction, provisioning from deployer~~ feat(runtime, deployer): extract load phase + provisioning to deployer Feb 20, 2024

chesedo reviewed Feb 22, 2024

View reviewed changes

jonaro00 force-pushed the deployer-runtime-provisioner branch from e178f2f to 44fb723 Compare February 22, 2024 23:01

iulianbarbu reviewed Feb 23, 2024

View reviewed changes

jonaro00 force-pushed the deployer-runtime-provisioner branch from 058637b to 2e8ee52 Compare February 26, 2024 17:59

jonaro00 added 24 commits February 26, 2024 21:25

wip: sketch of new macro expansion

8a0854c

wip: make room for provisioning in deployer

ecca342

misc: ignore lockfile patches when making cargo-chef recipe

f34e461

wip: macro, load, and start parts compile

4a8f374

wip: use Response object for Shuttle resource inputs

3e3ea81

wip: resource input/output schema

c0c34fc

wip: local provisioner

1127955

feat!: adjacent tag

897d5e9

feat: local provisioner, update secrets and qdrant plugins

e7385ee

feat: use untagged enums for optional resource requests

7e2f866

feat: deployer<->provisioner functional prototype

926e1a3

fix: refactor & comment local provisioner

0e1a181

refactor: remove Factory trait

e41c778

nit: builder option

ae84742

fix: proto deprecated fields

b6db5f4

nit

9e09c57

attempt unfolding macro

9e3ffc6

Revert "attempt unfolding macro"

cf66f38

This reverts commit 8c72605.

refactor: load phase

f11d9c6

fix: clippy, provisioner parity

e3d0edf

refactor: functions instead of macros

12e1c46

nit: no mut refrence

d9a7fd0

refactor: early return parse error, match logic

78da294

refactor: early return version mismatch

ab00351

jonaro00 force-pushed the deployer-runtime-provisioner branch from 361159c to 5af40fb Compare February 26, 2024 20:32

jonaro00 added 9 commits February 26, 2024 21:35

fmt

23ed79d

fix: runtime integration, resources

558cefc

fix: don't use common-tests

76c4b55

fix: c-s tests

db459a1

nit: docs

f449e19

nit: docs

1d409dc

fix: import

09eccfe

bump examples to upstream/main

0c4b07d

ci: unstable

468beb7

jonaro00 marked this pull request as ready for review February 26, 2024 22:49

chesedo reviewed Feb 27, 2024

View reviewed changes

jonaro00 added 4 commits February 27, 2024 10:48

fix: kill old deployments as late as possible

0c835b6

docs

ba5cd5f

fix: runtime no claims feature

ac95acd

refactor: new provisioning structure in c-s

5e18c21

chesedo approved these changes Feb 27, 2024

View reviewed changes

jonaro00 changed the title ~~feat(runtime, deployer): extract load phase + provisioning to deployer~~ feat(runtime, deployer)!: extract load phase + provisioning to deployer Feb 27, 2024

jonaro00 changed the title ~~feat(runtime, deployer)!: extract load phase + provisioning to deployer~~ feat(runtime, deployer)!: extract load phase + provisioning to deployer, resource update Feb 27, 2024

jonaro00 added 2 commits February 28, 2024 13:52

nit: comment

eba6245

Merge remote-tracking branch 'upstream/main' into deployer-runtime-pr…

b06b5b3

…ovisioner

iulianbarbu reviewed Feb 28, 2024

View reviewed changes

cargo-shuttle/src/lib.rs Outdated Show resolved Hide resolved

cargo-shuttle/src/lib.rs Show resolved Hide resolved

examples Outdated Show resolved Hide resolved

.circleci/config.yml Outdated Show resolved Hide resolved

ci: not unstable

d1d6879

iulianbarbu approved these changes Feb 28, 2024

View reviewed changes

oddgrd reviewed Feb 28, 2024

View reviewed changes

codegen/src/shuttle_main/mod.rs Outdated Show resolved Hide resolved

cargo-shuttle/src/provisioner_server.rs Show resolved Hide resolved

deployer/src/deployment/run.rs Show resolved Hide resolved

jonaro00 added 2 commits February 28, 2024 14:54

nit: instrument load/provision phases, move load function

595a351

nit: codegen var names

a426afa

jonaro00 merged commit ba57785 into main Feb 28, 2024
31 checks passed

jonaro00 deleted the deployer-runtime-provisioner branch February 28, 2024 14:26

jonaro00 mentioned this pull request Feb 29, 2024

fix(cargo-shuttle): windows build #1648

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(runtime, deployer)!: extract load phase + provisioning to deployer, resource update #1628

feat(runtime, deployer)!: extract load phase + provisioning to deployer, resource update #1628

jonaro00 commented Feb 14, 2024 •

edited

Loading

chesedo left a comment

iulianbarbu left a comment

chesedo left a comment

chesedo left a comment

oddgrd left a comment

feat(runtime, deployer)!: extract load phase + provisioning to deployer, resource update #1628

feat(runtime, deployer)!: extract load phase + provisioning to deployer, resource update #1628

Conversation

jonaro00 commented Feb 14, 2024 • edited Loading

Description of change

How has this been tested? (if applicable)

chesedo left a comment

Choose a reason for hiding this comment

iulianbarbu left a comment

Choose a reason for hiding this comment

chesedo left a comment

Choose a reason for hiding this comment

chesedo left a comment

Choose a reason for hiding this comment

oddgrd left a comment

Choose a reason for hiding this comment

jonaro00 commented Feb 14, 2024 •

edited

Loading