Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: --no-git to cargo shuttle init #1501

Merged
merged 5 commits into from
Jan 4, 2024
Merged

feat: --no-git to cargo shuttle init #1501

merged 5 commits into from
Jan 4, 2024

Conversation

dhruvdabhi101
Copy link
Contributor

Description of change

  • Added a new property in InitArgs struct.
  • Used that new property value and passed to the generate_project function
  • changed init.rs file so that --no-git flag can work

Closes #1497

How has this been tested? (if applicable)

I haven't tested this yet, I just wanted to know if gist of this code looks good or do i need to change anything.

jonaro00
jonaro00 approved these changes Dec 29, 2023
View reviewed changes
Copy link
Member

@jonaro00 jonaro00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are looking good! Since this change is so simple, I would say it could pass without testing at all 😅 . For the sake of it, you can check it manually with just cargo run -p cargo-shuttle -- init ...

@dhruvdabhi101
Copy link
Contributor Author

The changes are looking good! Since this change is so simple, I would say it could pass without testing at all 😅 . For the sake of it, you can check it manually with just cargo run -p cargo-shuttle -- init ...

sure 😃

@oddgrd
Copy link
Contributor

oddgrd commented Dec 29, 2023

Hey @dhruvdabhi101, thanks for this! It looks like you also need to run a cargo fmt.

@dhruvdabhi101
Copy link
Contributor Author

Hey @dhruvdabhi101, thanks for this! It looks like you also need to run a cargo fmt.

Yeah, I'll do that ASAP. : )

@jonaro00 jonaro00 merged commit 05c5e53 into shuttle-hq:main Jan 4, 2024
oddgrd pushed a commit that referenced this pull request Jan 8, 2024
@dhruvdabhi101 @jonaro00 @oddgrd
feat: --no-git to cargo shuttle init (#1501)
076370f 
* add: --no-git flag while cargo shuttle init command

* ref: fixed some fmt issues

* chore: Update args.rs ( rephrasing to make docs simple )

Co-authored-by: jonaro00 <[email protected]>

* chore: fmt fixes

---------

Co-authored-by: jonaro00 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonaro00 jonaro00 jonaro00 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: Add --no-git to cargo shuttle init
3 participants
@dhruvdabhi101 @oddgrd @jonaro00