Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cargo-shuttle): check project name available #1279

Merged
merged 7 commits into from
Oct 2, 2023
Merged

feat(cargo-shuttle): check project name available #1279

merged 7 commits into from
Oct 2, 2023

Conversation

jonaro00
Copy link
Member

@jonaro00 jonaro00 commented Sep 27, 2023 •
edited
Loading

Description of change

image
image

What still remains:

  • Should we allow user to use the name even though it is taken? Prompt y/n for the rename?
    • It's a bit tricky and not a killer. Using --name gets you around this check.

Bonus:
image

How has this been tested? (if applicable)

All 3 scenarios tested locally
Updated tests

@jonaro00 jonaro00 force-pushed the feat/eng-1369-project-name-availability-check branch from 7cc854a to 077d9b2 Compare September 27, 2023 22:25
chesedo
chesedo approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@chesedo chesedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

oddgrd
oddgrd approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@oddgrd oddgrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one nit/question, but feel free to merge if you think it's clear as is.

@jonaro00 jonaro00 merged commit da18b3b into shuttle-hq:main Oct 2, 2023
@jonaro00 jonaro00 deleted the feat/eng-1369-project-name-availability-check branch October 2, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chesedo chesedo chesedo approved these changes

@oddgrd oddgrd oddgrd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonaro00 @chesedo @oddgrd