Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cleanup for 0.28.0 #1278

Merged
merged 10 commits into from
Oct 3, 2023
Merged

fix: cleanup for 0.28.0 #1278

merged 10 commits into from
Oct 3, 2023

Conversation

jonaro00
Copy link
Member

Description of change

How has this been tested? (if applicable)

iulianbarbu
iulianbarbu approved these changes Sep 27, 2023
View reviewed changes
@jonaro00
Copy link
Member Author

Waiting with merge until release is closer

oddgrd
oddgrd approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@oddgrd oddgrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We're certain that nothing depends on openssl in cargo-shuttle now, right? We could run the QA jobs for mac and windows on this PR to ensure it works, but it's probably overkill.

@oddgrd oddgrd merged commit 88e7519 into shuttle-hq:main Oct 3, 2023
@jonaro00 jonaro00 deleted the fixes-0.28 branch October 3, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iulianbarbu iulianbarbu iulianbarbu approved these changes

@orhun orhun orhun approved these changes

@oddgrd oddgrd oddgrd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jonaro00 @iulianbarbu @orhun @oddgrd