fix: span names, log levels and messages #1213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Missed a detail on colorize. We can probably remove tracing feature from codegen now because of the move. |
orhun
reviewed
Sep 9, 2023
runtime/src/alpha/mod.rs
Outdated
| @@ -64,6 +64,43 @@ pub async fn start(loader: impl Loader<ProvisionerFactory> + Send + 'static) { | |||
| } | |||
| }; | |||
|
|
|||
| // this is handled after arg parsing to not interfere with --version above | |||
| if cfg!(feature = "setup-tracing") { | |||
There was a problem hiding this comment.
Why this was moved to here from codegen?
There was a problem hiding this comment.
It is not needed in codegen, and it interfered with the arg parsing of runtime, which the comment states.
It might be readded because of |
oddgrd
reviewed
Sep 11, 2023
iulianbarbu
reviewed
Sep 11, 2023
Co-authored-by: Oddbjørn Grødem <[email protected]>
iulianbarbu
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
How has this been tested? (if applicable)