deployer: fixed runtime logs receiving #1108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iulianbarbu
force-pushed
the
feature/eng-778-runtime-or-something-is-not-returning-logs
branch
from
8906ee9 to
d3964dd
Compare
chesedo
reviewed
Jul 25, 2023
There was a problem hiding this comment.
@iulianbarbu Looks good 🙏
Just need to remove some CI comments and a test comment
iulianbarbu
force-pushed
the
feature/eng-778-runtime-or-something-is-not-returning-logs
branch
from
41f65ff to
efe1133
Compare
iulianbarbu
changed the title
iulianbarbu
changed the title
iulianbarbu
deleted the
feature/eng-778-runtime-or-something-is-not-returning-logs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Fixed runtime logs sending to the deployer.
How has this been tested? (if applicable)
Locally, by deploying a project and querying for the service logs. I was able to see the rocket logs of a rocket service.