chore: bump local pgsql from 11 to 14 #1073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bayou-brogrammer
changed the title
|
@lecoqjacob it seems like 1 test is failing. Can you reproduce it locally? |
|
Password hashing changed in v14 of psql to use sham-sha-256. |
chesedo
reviewed
Jul 13, 2023
| @@ -333,7 +333,7 @@ fn db_type_to_config(db_type: Type) -> EngineConfig { | |||
| match db_type { | |||
| Type::Shared(SharedEngine::Postgres) => EngineConfig { | |||
| r#type: "shared_postgres".to_string(), | |||
| image: "docker.io/library/postgres:11".to_string(), | |||
There was a problem hiding this comment.
This tries to match the same version that is being provisioned for RDS instances to make local and prod identical. I might have missed when the RDS instances also got bumped?
There was a problem hiding this comment.
I checked in the console now and a bit more than half of our RDS instances are at 14 (the newer ones), and the older half is at 13. I don't see any below 13, and the most recent instance is actually 15. 😄 We don't explicitly set the version in provisioner when we provision RDS dbs, so perhaps it just uses latest 🤔
oddgrd
approved these changes
Sep 20, 2023
iulianbarbu
pushed a commit
to GugaGongadze/shuttle
that referenced
this pull request
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Bumps the local version of pgsql to match our deployed versions
Addresses: #1072