Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming convention #526

Open
fredo opened this issue Aug 27, 2024 · 1 comment
Open

Naming convention #526

fredo opened this issue Aug 27, 2024 · 1 comment

Comments

@fredo
Copy link
Contributor

fredo commented Aug 27, 2024

We are facing confusions because we do not have proper naming. This results in confusion during discussions, naming in code is not consistent and we are transporting inner workings to the public in the engine room release with our explorer.
I suggest we come up with consistent naming.

I'll start a list below. Please feel free to add other objects/processes which we should name and feel free to add suggestions.

General

  • Overall shutterized flow

Components

  • SubmitEncryptedTransaction
  • Plain text transaction
  • inclusion time
  • identity

States

  • not found
  • pending encrypted transaction
  • submitted
  • released keys
  • included/executed

Suggestions

General

  • Overall shutterized flow -> Shielded Transaction (derived from the marketing rebranding)

Components

  • SubmitEncryptedTransaction -> Encrypted Transaction / Submission Transaction
  • Plain text transaction -> User Transaction / User Operation
  • inclusion time

States

  • not found
  • pending encrypted transaction
  • submitted
  • released keys
  • included/executed
@fredo
Copy link
Contributor Author

fredo commented Aug 28, 2024

Current Votes

Overall Flow

Shielded Transaction Flow 5

SubmitEncryptedTransaction Call

Encrypted Transaction 2
Encrypted Mempool Transaction 1
Submission Transaction 1
Sequencer Transaction 2

Encrypted data (call data of the above)

encrypted data 1
encrypted User Transaction 4

The user's transaction

User Transaction 5

Decided

Happy Case States

Not Found
Pending Encrypted Transaction
Submitted
Pending User Transaction
Included

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant