Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keypers reject keys and key shares messages from different sets #484

Open
jannikluhn opened this issue Jul 4, 2024 · 0 comments
Open

Keypers reject keys and key shares messages from different sets #484

jannikluhn opened this issue Jul 4, 2024 · 0 comments

Comments

@jannikluhn
Copy link
Contributor

When a keyper receives a message for an eon in which they are not a keyper, they reject it:

  • _, isKeyper, err := queries.GetKeyperIndex(ctx, int64(key.Eon), handler.config.GetAddress())
    if err != nil {
    return pubsub.ValidationReject, err
    }
    if !isKeyper {
    log.Debug().Uint64("eon", key.Eon).Msg("Ignoring decryptionKey for eon; we're not a Keyper")
    return pubsub.ValidationReject, nil
    }
  • _, isKeyper, err := queries.GetKeyperIndex(ctx, int64(keyShare.Eon), handler.config.GetAddress())
    if err != nil {
    return pubsub.ValidationReject, err
    }
    if !isKeyper {
    log.Debug().Uint64("eon", keyShare.Eon).Msg("Ignoring decryptionKey for eon; we're not a Keyper")
    return pubsub.ValidationReject, nil
    }

This is a problem because it means that especially around the time of a keyper set transition, messages have a hard time propagating through the network.

Instead, keypers should validate decryption keys against the eon key broadcasted via the broadcast contract. For decryption key shares it is tricky because the eon key shares are unknown to the public. A potential solution would be to require shares messages to be signed by the originating keyper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant