Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS task runner uses hardcoded paths #1

Open
1 of 3 tasks
shrayasr opened this issue Oct 9, 2017 · 14 comments
Open
1 of 3 tasks

VS task runner uses hardcoded paths #1

shrayasr opened this issue Oct 9, 2017 · 14 comments

Comments

@shrayasr
Copy link
Owner

shrayasr commented Oct 9, 2017

/u/opium_tm says (permalink):

VS runner is implemented completely wrong way. Paths to VS are hardcoded in lib. For VS before 2017 you should get installation paths from well known registry branch. For VS 2017 you should use documented COM interfaces to enumerate (possibly side by side) VS 2017 installations.

Fair point. Everything in the project is in a "works-for-me" kind of situation.

Basically we're currently at:

  • Make it work
  • Make it right
  • Make it fast
@SpartanX1
Copy link

Hello I am interested in solving this issue. Are you still active in this project?

@shrayasr
Copy link
Owner Author

Oh yes. I use it everyday :) Please go ahead.

@SpartanX1
Copy link

Hey you did not mention how to and where to place the config file?

@shrayasr
Copy link
Owner Author

shrayasr commented Apr 22, 2018

Which config file @SpartanX1? The base iko config is placed at ~/iko.toml

@SpartanX1
Copy link

Do i need to install toml or something ? or just create a file with this name

@SpartanX1
Copy link

I have made changes for vs17 , but i need to check how it works.
Here's the syntax. I hope there is a space between path and @params?

var path = GetVisualStudioInstallationFolder();

Process.Start("cmd", $@"/c start "+path+" "[email protected]);

@SpartanX1
Copy link

I am not clear on how to run and test the application.
Could you please provide the steps? @shrayasr

@shrayasr
Copy link
Owner Author

Do i need to install toml or something ? or just create a file with this name

Not at all. TOML is a plain text file in a certain format. Just creating a file with the name is enough.

I am not clear on how to run and test the application.
Could you please provide the steps?

  • Build it
  • dotnet \path\to\iko.dll <task name>

This assumes that you have already defined the tasks in the TOML file. In your case, the TOML file could be:

[ikosln]
cmd = 'vs17'
path = 'c:\users\spartanx1\projects\iko\iko.sln'

and run it as

dotnet \path\to\iko.dll ikosln

@SpartanX1
Copy link

Thanks I will test it out

@shrayasr
Copy link
Owner Author

You're welcome. Thank you for working on this 🎉

@SpartanX1
Copy link

Hello could you review my pull request @shrayasr

@shrayasr
Copy link
Owner Author

Will do it soon, @SpartanX1. Held up at work at the moment

@SpartanX1
Copy link

Sure thanks:)

@aintabb
Copy link

aintabb commented Aug 19, 2020

@shrayasr Is this issue still open?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants