Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deserializer spirals into endless recursion on an empty input #5

Closed
soulthreads opened this issue Dec 1, 2017 · 3 comments
Closed
Labels

Comments

@soulthreads
Copy link

As a result, you get a stack overflow.

How to reproduce: call VdfConvert.Deserialize(String.Empty)

@shravan2x
Copy link
Owner

I think the problem is at https://github.com/shravan2x/Gameloop.Vdf/blob/master/Gameloop.Vdf/VdfSerializer.cs#L26, where the return value is not checked. I couldn't get a stack trace back, let me try to debug it manually.

@shravan2x
Copy link
Owner

shravan2x commented Dec 1, 2017

I've fixed the issue and will release 0.4.4 soon. You can then wrap VdfConvert.Deserialize(someString) with a try-catch and handle VdfExceptions.

Feel free to reopen if the issue persists.

@soulthreads
Copy link
Author

Thank you for the quick response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants