CI fix Attempt #3 #1810
Merged
CI fix Attempt #3 #1810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronycsdu
approved these changes
Nov 13, 2024
CodSpeed Performance ReportMerging #1810 will not alter performanceComparing Summary
|
conorbros
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1808 was a success, but it only fixed debug builds, leaving all of the release builds broken as well.
To fix this, this PR includes the
${{ matrix.cargo_flags }}in the clean flags.This will include
--releasefor release builds and nothing for debug builds, ensuring that release builds also have j4rs built from scratch, same as debug builds.I'm not sure why #1808 seemed to completely fix the issue, maybe the main branch caches hadnt actually been written to yet.