feat: would like patch numbers to match between iOS and Android

[eseidel]

Right now if you publish a patch to Android and then a patch to iOS (for the same app), they will end up with patch number "1" and "2" respectively. This is confusing to some users who expect the patch numbers to match for the "same patch". This also causes some complexity for us in the console and could make sense to want to allow users to just mark one patch live and have it affect all OSes.

[felangel]

Agreed this should be fairly straightforward to implement since it’s only a CLI change.

[anderscheow]

Just for my use case:

App is showing version + patch in About screen. For example 1.0.1 (13) - Patch 1

Current behaviour:
Android: 1.0.1 (13) - Patch 1
iOS: 1.0.1 (13) - Patch 2

Expected behaviour:
Android: 1.0.1 (13) - Patch 1
iOS: 1.0.1 (13) - Patch 1

[anderscheow]

@eseidel @felangel any idea when this will get implemented?

[eseidel]

We currently have no schedule for this, no. We were discussing something similar yesterday which is that these numbers are currently just "names" and the fact that we have them auto-increment on a per-platform basis is confusing in other contexts. We could easily change the name to something else. The underlying "id" of the patch is just our database id for the patch artifact table row.

[eseidel]

Dupe with #1762?

[alejojarahi]

Hi, I did not want to generate different patches per platform, i was testing the functionality of using shorebird patch --platforms android,ios #1762 but it doesn't work well if to use iOS exclusive flags, for example --export-options-plist so I don't know if this is a bug, something that is not covered, or am I doing something wrong, thanks.

@eseidel @felangel

shorebird patch --platforms=android,ios --flavor=dev --release-version=1.0.0 --track=beta --export-options-plist=ios/ExportOptions.plist --no-confirm

Shorebird version: 1.5.5
Console error:

⠋ Fetching apps...
✓ Fetching apps (0.4s)
⠋ Fetching releases...
✓ Fetching releases (0.2s)
⠋ Fetching aab artifact...
✓ Fetching aab artifact (0.2s)
⠋ Downloading aab...
⠙ Downloading aab (0%)... (0.2s)
⠹ Downloading aab (9%)... (0.4s)
⠸ Downloading aab (24%)... (0.7s)
⠼ Downloading aab (43%)... (0.9s)
⠴ Downloading aab (63%)... (1.2s)
⠦ Downloading aab (82%)... (1.4s)
✓ Downloading aab (100%) (1.7s)
⠋ Building patch with Flutter 3.24.5 (3faf56aafa)...
✗ Failed to build: [  +13 ms] Could not find an option named "export-options-plist".

[   +1 ms] Run 'flutter -h' (or 'flutter <command> -h') for available flutter commands and options. (6.2s)

If you aren't sure why this command failed, re-run with the --verbose flag to see more information.

[bryanoltman]

@alejojarahi This doesn't seem related to this bug. Would you mind opening a new one and clearly describing your problem there?