Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: mark patches good after delay #80

Open
eseidel opened this issue Apr 25, 2024 · 0 comments
Open

feat: mark patches good after delay #80

eseidel opened this issue Apr 25, 2024 · 0 comments

Comments

@eseidel
Copy link

eseidel commented Apr 25, 2024

Right now we mark a patch as "good" (successfully booted) after Dart_Init() completes. Which only verifies that we successfully read in the snapshot.

Thus if developer pushes a patch which crashes during startup (but after Dart_Init) we won't catch the crash.

We should instead either hook into a later callback (like first frame) or probably easier is to just wait a few seconds before we mark a patch as good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant