Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if PriceRule unit property is really nullable #2593

Open
mitelg opened this issue Sep 20, 2023 · 0 comments
Open

Check if PriceRule unit property is really nullable #2593

mitelg opened this issue Sep 20, 2023 · 0 comments

Comments

@mitelg
Copy link
Contributor

mitelg commented Sep 20, 2023

\Shopware\Bundle\StoreFrontBundle\Struct\Product\PriceRule::$unit is nullable, but probably it is mandatory.

Check if it is really nullable. if not, make sure it is always set and throw meaningful exceptions otherwise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant