Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last commit breaks pytest-black under poetry #45

Closed
tr11 opened this issue Jul 5, 2020 · 2 comments
Closed

Last commit breaks pytest-black under poetry #45

tr11 opened this issue Jul 5, 2020 · 2 comments

Comments

@tr11
Copy link
Contributor

tr11 commented Jul 5, 2020

The commit 584c2d1 for pipenv support breaks existing installs with the poetry package manager. This is in all similar to the bug described in peterjc/flake8-black#23, which is referenced from the pipenv issue listed on the commit.

As a workaround, one can do what's mentioned on peterjc/flake8-black#23 (comment), but it would be great if one can just install pytest-black as before the commit above.

@paddycarey
Copy link

Hi @tr11 thanks for the report.

This is somewhat frustrating, it seems we can support either pipenv or poetry, but not both at the same time until black releases a non-prerelease version. I'm inclined to leave the versioning as-is and add the same workaround note to the README as in the linked flake8-black issue.

I'll try to get to this soon, but happy to accept a PR with the updates too.

@tr11
Copy link
Contributor Author

tr11 commented Jul 16, 2020

@paddycarey, I'll submit a PR this weekend to add the info to the readme. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants