Skip to content
This repository has been archived by the owner on Jul 27, 2024. It is now read-only.

Ensure consistent spaces around | in variable expressions #73

Closed
macournoyer opened this issue Dec 10, 2020 · 0 comments · Fixed by #267
Closed

Ensure consistent spaces around | in variable expressions #73

macournoyer opened this issue Dec 10, 2020 · 0 comments · Fixed by #267
Assignees
@jmignac
Labels
e:3 Effort: 3 linter Check related issues p:low Priority (or Impact): Low

Comments

@macournoyer
Copy link
Contributor

Bad:

{{ 'hello'|upcase }}
{{ 'hello'| upcase }}
{{ 'hello' |upcase }}

Good:

{{ 'hello' | upcase }}

SpaceInsideBraces already check the spaces near the braces. I think it would make sense to add these check in there too.
@macournoyer macournoyer added the good first issue Good for newcomers label Jan 6, 2021
@charlespwd charlespwd added cla-needed linter Check related issues and removed cla-needed labels Feb 25, 2021
@charlespwd charlespwd added p:low Priority (or Impact): Low e:3 Effort: 3 and removed good first issue Good for newcomers labels Mar 25, 2021
@jmignac jmignac self-assigned this Mar 29, 2021
@jmignac jmignac mentioned this issue Apr 20, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jmignac jmignac

Labels
e:3 Effort: 3 linter Check related issues p:low Priority (or Impact): Low
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add space around filter pipeline check Shopify/theme-check
3 participants
@macournoyer @charlespwd @jmignac