This repository has been archived by the owner on Jul 27, 2024. It is now read-only.
Handle variable lookup as names in UnusedAssign #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `{{ [some_var] }}` syntax is valid Liquid. When this happens, the
tree gives us a Liquid::VariableLookup for the node.value.name (instead
of a string).
To handle those cases, we simply return node.value.name.name.
It's not entirely future proof, but fixing this in Shopify/liquid seemed non-trivial.
Fixes #576
mgmanzella
approved these changes
Jul 21, 2022
karreiro
approved these changes
Jul 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
{{ [some_var] }}syntax is valid Liquid. When this happens, thetree gives us a Liquid::VariableLookup for the node.value.name (instead
of a string).
To handle those cases, we simply return node.value.name.name.
It's not entirely future proof, but fixing this in Shopify/liquid seemed non-trivial.
Fixes #576