This repository has been archived by the owner on Jul 27, 2024. It is now read-only.
Add AssetPreload check #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey 👋
The goal of this check is to discourage people from preloading assets using plain HTML in cases when it is possible to use Liquid filters instead.
It is sometimes the case that
<link rel="preload" ...>is positioned late in the<head>, preventing the browser from discovering it early. In addition, this manual approach is not automatically converted toLinkheader so Shopify is not able to forward it to Early Hints response. These issues are not present when using Liquid filters mentioned above.